Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core 1 Backport] Fix cookies on Cypress + Improve script loading failure logging #3384

Conversation

anagstef
Copy link
Member

This PR backports 2 fixes from Core 2:

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 馃悰 Bug fix
  • 馃専 New feature
  • 馃敤 Breaking change
  • 馃摉 Refactoring / dependency upgrade / documentation
  • other:

* fix(clerk-js): Improve logging for CAPTCHA script loading errors

* fix(clerk-js): Remove the generic CAPTCHA console error

(cherry picked from commit 34befee)
* fix(clerk-js): Use first-party cookies when running on Cypress

* fix(clerk-js): Create isCypress util

(cherry picked from commit 7b213d5)
@anagstef anagstef self-assigned this May 15, 2024
@anagstef anagstef requested a review from a team as a code owner May 15, 2024 09:58
Copy link

changeset-bot bot commented May 15, 2024

馃 Changeset detected

Latest commit: ea1bea3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef panteliselef self-requested a review May 15, 2024 10:17
@anagstef anagstef merged commit fce528b into release/v4 May 15, 2024
6 checks passed
@anagstef anagstef deleted the stefanos/core-2299-backport-cypress-fix-logging-latest-changes-to-core-1 branch May 15, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants