-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(testing): Add experimental console warning on Cypress setup #3395
chore(testing): Add experimental console warning on Cypress setup #3395
Conversation
🦋 Changeset detectedLatest commit: 3a21c15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with this, but why didn't we lunch this in @clerk/testing/experimental/cypress
?
@panteliselef it's a bit complicated. The actual package is not experimental, the Clerk + Cypress integration is. |
@anagstef
Just because i think warning in tests are usually overlooked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a note about this to the README, too
@panteliselef The point I was trying to make is that when we fully support Cypress, no actions will be needed for this package. This package just implements testing tokens, which works as expected. This warning is just informative about the Cypress support in general. |
Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
…e-the-clerktesting-package
Description
This PR adds the following console message on the node process that runs the
clerkSetup
function from@clerk/testing/cypress
:Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change