fix(elements): Verification form not submitting after returning from ChooseStrategy without a selection
#3425
Conversation
tmilewski
requested review from
alexcarpenter,
BRKalow,
LekoArts and
panteliselef
馃 Changeset detectedLatest commit: e2c1ad2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!snapshot |
|
Hey @tmilewski - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/backend@1.2.1-snapshot.veb34b56 --save-exact
npm i @clerk/chrome-extension@1.0.14-snapshot.veb34b56 --save-exact
npm i @clerk/clerk-js@5.5.1-snapshot.veb34b56 --save-exact
npm i @clerk/elements@0.5.0-snapshot.veb34b56 --save-exact
npm i @clerk/clerk-expo@1.1.6-snapshot.veb34b56 --save-exact
npm i @clerk/express@0.0.10-snapshot.veb34b56 --save-exact
npm i @clerk/fastify@1.0.11-snapshot.veb34b56 --save-exact
npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact
npm i @clerk/nextjs@5.1.1-snapshot.veb34b56 --save-exact
npm i @clerk/clerk-react@5.2.1-snapshot.veb34b56 --save-exact
npm i @clerk/remix@4.0.12-snapshot.veb34b56 --save-exact
npm i @clerk/clerk-sdk-node@5.0.9-snapshot.veb34b56 --save-exact
npm i @clerk/shared@2.2.1-snapshot.veb34b56 --save-exact
npm i @clerk/testing@1.1.4-snapshot.veb34b56 --save-exact |
| 'NAVIGATE.PREVIOUS': { | ||
| description: 'Go to Idle, and also tell firstFactor to go to Pending', | ||
| target: 'Idle', | ||
| actions: sendTo(({ self }) => self.getSnapshot().children['firstFactor']!, { type: 'NAVIGATE.PREVIOUS' }), |
There was a problem hiding this comment.
What would happen if children['firstFactor'] is undefined?
There was a problem hiding this comment.
This isn't the best way to handle this in this scenario. I used it as I was working on something else where the children approach made sense. I've updated it.
That said, technically, it wouldn't ever be undefined in this scenario as firstFactor is invoked in this state's parent.
| @@ -145,6 +145,7 @@ const SignInVerificationMachine = setup({ | |||
| }, | |||
| guards: { | |||
| isResendable: ({ context }) => context.resendable || context.resendableAfter === 0, | |||
| isNeverResendable: ({ context }) => context.currentFactor?.strategy === 'password', | |||
There was a problem hiding this comment.
Aren't there more strategies that are never resendable?
For example: passkey, google_one_tap, saml
There was a problem hiding this comment.
There are, though I wasn't looking to address each of them in this PR. Especially, as passkey and google_one_tap haven't been integrated yet. While retaining the other flow isn't ideal, it doesn't cause any issues either.
tmilewski
force-pushed
the
elements/inspector
branch
from
2fb25bf
to
f72b416
Compare
tmilewski
force-pushed
the
elements/fix-choose-strategy-go-back
branch
from
8543b0c
to
b87a7d3
Compare
|
Pushing through as integration tests are having issues unrelated to this PR. |
Description
Problem: The form wasn't submitting after the
NAVIGATE.PREVIOUSevent from theChooseStrategystate.Reason: The top-level state was in the correct place, but it wasn't being propagated to First Factor so the
SUBMITevent was sent toChooseStrategyand notPendingas it should've been.Solution: Propagate the event to the First Factor child machine.
Adds a
NeverRetriablestate toPendingso as not to run the countdown, if not necessary. Ultimately, making debugging a bit easier.Fixes SDK-1765
Fixes SDK-1766
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change