fix(remix): RequestInit.duplex now is required if body is provided in undici #3495

octoper · 2024-06-03T06:43:52Z

Description

RequestInit.duplex now is required if body is provided:

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-06-03T06:43:56Z

🦋 Changeset detected

Latest commit: f6fb0eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/remix	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

octoper · 2024-06-03T06:47:12Z

!snapshot

clerk-cookie · 2024-06-03T06:51:46Z

Hey @octoper - the snapshot version command generated the following package versions:

Package	Version
@clerk/backend	1.2.2-snapshot.v72984d5
@clerk/chrome-extension	1.0.17-snapshot.v72984d5
@clerk/clerk-js	5.6.0-snapshot.v72984d5
@clerk/elements	0.6.0-snapshot.v72984d5
@clerk/clerk-expo	1.1.9-snapshot.v72984d5
@clerk/express	0.0.11-snapshot.v72984d5
@clerk/fastify	1.0.13-snapshot.v72984d5
gatsby-plugin-clerk	5.0.0-beta.45
@clerk/localizations	2.4.4-snapshot.v72984d5
@clerk/nextjs	5.1.4-snapshot.v72984d5
@clerk/clerk-react	5.2.3-snapshot.v72984d5
@clerk/remix	4.0.14-snapshot.v72984d5
@clerk/clerk-sdk-node	5.0.10-snapshot.v72984d5
@clerk/shared	2.2.2-snapshot.v72984d5
@clerk/testing	1.1.6-snapshot.v72984d5
@clerk/themes	2.1.9-snapshot.v72984d5
@clerk/types	4.6.0-snapshot.v72984d5

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.2.2-snapshot.v72984d5 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.17-snapshot.v72984d5 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.6.0-snapshot.v72984d5 --save-exact

@clerk/elements

npm i @clerk/elements@0.6.0-snapshot.v72984d5 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.1.9-snapshot.v72984d5 --save-exact

@clerk/express

npm i @clerk/express@0.0.11-snapshot.v72984d5 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.13-snapshot.v72984d5 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.4-snapshot.v72984d5 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.1.4-snapshot.v72984d5 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.3-snapshot.v72984d5 --save-exact

@clerk/remix

npm i @clerk/remix@4.0.14-snapshot.v72984d5 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.10-snapshot.v72984d5 --save-exact

@clerk/shared

npm i @clerk/shared@2.2.2-snapshot.v72984d5 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.6-snapshot.v72984d5 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.9-snapshot.v72984d5 --save-exact

@clerk/types

npm i @clerk/types@4.6.0-snapshot.v72984d5 --save-exact

octoper · 2024-06-03T07:13:54Z

!snapshot

clerk-cookie · 2024-06-03T07:18:46Z

Hey @octoper - the snapshot version command generated the following package versions:

Package	Version
@clerk/backend	1.2.2-snapshot.vef44e76
@clerk/chrome-extension	1.0.17-snapshot.vef44e76
@clerk/clerk-js	5.6.0-snapshot.vef44e76
@clerk/elements	0.6.0-snapshot.vef44e76
@clerk/clerk-expo	1.1.9-snapshot.vef44e76
@clerk/express	0.0.11-snapshot.vef44e76
@clerk/fastify	1.0.13-snapshot.vef44e76
gatsby-plugin-clerk	5.0.0-beta.45
@clerk/localizations	2.4.4-snapshot.vef44e76
@clerk/nextjs	5.1.4-snapshot.vef44e76
@clerk/clerk-react	5.2.3-snapshot.vef44e76
@clerk/remix	4.0.14-snapshot.vef44e76
@clerk/clerk-sdk-node	5.0.10-snapshot.vef44e76
@clerk/shared	2.2.2-snapshot.vef44e76
@clerk/testing	1.1.6-snapshot.vef44e76
@clerk/themes	2.1.9-snapshot.vef44e76
@clerk/types	4.6.0-snapshot.vef44e76

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.2.2-snapshot.vef44e76 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.17-snapshot.vef44e76 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.6.0-snapshot.vef44e76 --save-exact

@clerk/elements

npm i @clerk/elements@0.6.0-snapshot.vef44e76 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.1.9-snapshot.vef44e76 --save-exact

@clerk/express

npm i @clerk/express@0.0.11-snapshot.vef44e76 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.13-snapshot.vef44e76 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.4-snapshot.vef44e76 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.1.4-snapshot.vef44e76 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.3-snapshot.vef44e76 --save-exact

@clerk/remix

npm i @clerk/remix@4.0.14-snapshot.vef44e76 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.10-snapshot.vef44e76 --save-exact

@clerk/shared

npm i @clerk/shared@2.2.2-snapshot.vef44e76 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.6-snapshot.vef44e76 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.9-snapshot.vef44e76 --save-exact

@clerk/types

npm i @clerk/types@4.6.0-snapshot.vef44e76 --save-exact

octoper · 2024-06-03T08:17:50Z

!snapshot

clerk-cookie · 2024-06-03T08:21:47Z

Hey @octoper - the snapshot version command generated the following package versions:

Package	Version
@clerk/backend	1.2.2-snapshot.vff20ad3
@clerk/chrome-extension	1.0.17-snapshot.vff20ad3
@clerk/clerk-js	5.6.0-snapshot.vff20ad3
@clerk/elements	0.6.0-snapshot.vff20ad3
@clerk/clerk-expo	1.1.9-snapshot.vff20ad3
@clerk/express	0.0.11-snapshot.vff20ad3
@clerk/fastify	1.0.13-snapshot.vff20ad3
gatsby-plugin-clerk	5.0.0-beta.45
@clerk/localizations	2.4.4-snapshot.vff20ad3
@clerk/nextjs	5.1.4-snapshot.vff20ad3
@clerk/clerk-react	5.2.3-snapshot.vff20ad3
@clerk/remix	4.0.14-snapshot.vff20ad3
@clerk/clerk-sdk-node	5.0.10-snapshot.vff20ad3
@clerk/shared	2.2.2-snapshot.vff20ad3
@clerk/testing	1.1.6-snapshot.vff20ad3
@clerk/themes	2.1.9-snapshot.vff20ad3
@clerk/types	4.6.0-snapshot.vff20ad3

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/backend@1.2.2-snapshot.vff20ad3 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.0.17-snapshot.vff20ad3 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.6.0-snapshot.vff20ad3 --save-exact

@clerk/elements

npm i @clerk/elements@0.6.0-snapshot.vff20ad3 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.1.9-snapshot.vff20ad3 --save-exact

@clerk/express

npm i @clerk/express@0.0.11-snapshot.vff20ad3 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.13-snapshot.vff20ad3 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.4.4-snapshot.vff20ad3 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.1.4-snapshot.vff20ad3 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.3-snapshot.vff20ad3 --save-exact

@clerk/remix

npm i @clerk/remix@4.0.14-snapshot.vff20ad3 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.10-snapshot.vff20ad3 --save-exact

@clerk/shared

npm i @clerk/shared@2.2.2-snapshot.vff20ad3 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.6-snapshot.vff20ad3 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.9-snapshot.vff20ad3 --save-exact

@clerk/types

npm i @clerk/types@4.6.0-snapshot.vff20ad3 --save-exact

.changeset/fifty-parents-juggle.md

packages/remix/src/ssr/utils.ts

anagstef

💯

… RequestInit

Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

…it-duplex-option-is-required-when

ariofrio · 2024-07-18T23:04:51Z

I'm getting the following error:

Error: cannot clone body after it is used
    at clone (.../build/server.js:36692:15)
    at new Request2 (.../build/server.js:37302:99)
    at new NodeRequest (.../build/server.js:37754:9)
    at NodeRequest.clone (.../build/server.js:37760:16)
    at patchRequest (.../node_modules/@clerk/remix/src/ssr/utils.ts:128:33)
    at loadOptions (.../node_modules/@clerk/remix/src/ssr/loadOptions.ts:15:43)
    at Object.getAuth2 (.../node_modules/@clerk/remix/src/ssr/getAuth.ts:15:25)

The problem is that my code looks like this:

export async function action(args: ActionArgs) {
  const formData = await args.request.formData();
  const auth = await getAuth(args);
  ...
}

In other words, the request body is read before calling clerk.getAuth. Since Clerk attempts to clone the request, this causes an error. Is it necessary to clone the request to work around this duplex issue?

The workaround is to always call getAuth first:

export async function action(args: ActionArgs) {
  const auth = await getAuth(args);
  const formData = await args.request.formData();
  ...
}

But this is error-prone and easy to forget to do or accidentally change in a large project. At the minimum, this should be documented in the Clerk Remix guide. Ideally, this limitation would be removed.

clerk-cookie added the backend label Jun 3, 2024

octoper changed the title ~~fix:~~ fix: RequestInit.duplex now is required if body is provided in Unidici Jun 3, 2024

octoper changed the title ~~fix: RequestInit.duplex now is required if body is provided in Unidici~~ fix: RequestInit.duplex now is required if body is provided in undici Jun 3, 2024

octoper self-assigned this Jun 3, 2024

octoper changed the title ~~fix: RequestInit.duplex now is required if body is provided in undici~~ fix(backend): RequestInit.duplex now is required if body is provided in undici Jun 3, 2024

clerk-cookie added remix and removed backend labels Jun 3, 2024

octoper force-pushed the vaggelis/sdk-1780-clerkremix-v4012-requestinit-duplex-option-is-required-when branch from ff20ad3 to 19e95a6 Compare June 10, 2024 14:43

octoper changed the title ~~fix(backend): RequestInit.duplex now is required if body is provided in undici~~ fix(remix): RequestInit.duplex now is required if body is provided in undici Jun 12, 2024

octoper requested review from anagstef, nikosdouvlis and dimkl June 12, 2024 11:22

octoper force-pushed the vaggelis/sdk-1780-clerkremix-v4012-requestinit-duplex-option-is-required-when branch from 4895e8f to a238328 Compare June 12, 2024 11:22

octoper marked this pull request as ready for review June 12, 2024 13:18

octoper force-pushed the vaggelis/sdk-1780-clerkremix-v4012-requestinit-duplex-option-is-required-when branch 2 times, most recently from 4b53af7 to 58ca606 Compare June 12, 2024 16:31

anagstef reviewed Jun 12, 2024

View reviewed changes

.changeset/fifty-parents-juggle.md Outdated Show resolved Hide resolved

anagstef reviewed Jun 12, 2024

View reviewed changes

packages/remix/src/ssr/utils.ts Show resolved Hide resolved

anagstef approved these changes Jun 12, 2024

View reviewed changes

octoper added 4 commits June 13, 2024 17:12

fix: Request#duplex now is required in unidici if body is provided in…

5bf45d6

… RequestInit

chore: update comment

3df2be5

chore: update comment

6732d3a

chore(repo): Add Changeset

ef2fabc

octoper and others added 4 commits June 13, 2024 17:12

fix(remix): Add duplex when body is readable stream

e6cd78b

fix(remix): Add duplex when sending a body

3d7068e

fix(remix): Patch request to have duplex='half' property

308d735

Update .changeset/fifty-parents-juggle.md

4d7a407

Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>

octoper force-pushed the vaggelis/sdk-1780-clerkremix-v4012-requestinit-duplex-option-is-required-when branch from 9db8246 to 4d7a407 Compare June 13, 2024 14:12

Merge branch 'main' into vaggelis/sdk-1780-clerkremix-v4012-requestin…

f6fb0eb

…it-duplex-option-is-required-when

anagstef merged commit 7ec5b1c into main Jun 14, 2024
15 checks passed

anagstef deleted the vaggelis/sdk-1780-clerkremix-v4012-requestinit-duplex-option-is-required-when branch June 14, 2024 14:33

clerk-cookie mentioned this pull request Jun 14, 2024

ci(repo): Version packages #3558

Merged

LekoArts mentioned this pull request Jun 17, 2024

@clerk/remix v4.0.12 RequestInit: duplex option is required when sending a body. #3440

Closed

4 tasks

octoper mentioned this pull request Jul 1, 2024

fix(remix): Fix issues caused by modifying duplex on Request #3645

Merged

9 tasks

ariofrio mentioned this pull request Jul 18, 2024

Duplex Changes in Remix prevent calling getAuth after body already is read #3759

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(remix): RequestInit.duplex now is required if body is provided in undici #3495

fix(remix): RequestInit.duplex now is required if body is provided in undici #3495

octoper commented Jun 3, 2024

changeset-bot bot commented Jun 3, 2024 •

edited

Loading

octoper commented Jun 3, 2024

clerk-cookie commented Jun 3, 2024

octoper commented Jun 3, 2024

clerk-cookie commented Jun 3, 2024

octoper commented Jun 3, 2024

clerk-cookie commented Jun 3, 2024

anagstef left a comment

ariofrio commented Jul 18, 2024 •

edited

Loading

fix(remix): RequestInit.duplex now is required if body is provided in undici #3495

fix(remix): RequestInit.duplex now is required if body is provided in undici #3495

Conversation

octoper commented Jun 3, 2024

Description

Checklist

Type of change

changeset-bot bot commented Jun 3, 2024 • edited Loading

🦋 Changeset detected

octoper commented Jun 3, 2024

clerk-cookie commented Jun 3, 2024

octoper commented Jun 3, 2024

clerk-cookie commented Jun 3, 2024

octoper commented Jun 3, 2024

clerk-cookie commented Jun 3, 2024

anagstef left a comment

Choose a reason for hiding this comment

ariofrio commented Jul 18, 2024 • edited Loading

changeset-bot bot commented Jun 3, 2024 •

edited

Loading

ariofrio commented Jul 18, 2024 •

edited

Loading