Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend,clerk-js,types): Support the new LinkedIn OAuth Provider #1772

Conversation

fragoulis
Copy link
Contributor

Description

LinkedIn has changed the OAuth flow by replacing it with OpenID Connect. We have already added support for this in the backend.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 馃悰 Bug fix
  • 馃専 New feature
  • 馃敤 Breaking change
  • 馃摉 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@fragoulis fragoulis requested a review from a team as a code owner September 25, 2023 08:47
@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

馃 Changeset detected

Latest commit: c7d8425

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@clerk/clerk-js Minor
@clerk/backend Minor
@clerk/types Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/localizations Patch
@clerk/clerk-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fragoulis fragoulis force-pushed the fragoulis/usr-340-js-support-the-new-linkedin-v2-oauth-provider branch from 0ec5bf3 to a929d10 Compare September 25, 2023 08:50
@fragoulis fragoulis force-pushed the fragoulis/usr-340-js-support-the-new-linkedin-v2-oauth-provider branch from 097f346 to 0b4094a Compare September 25, 2023 09:39
packages/types/src/oauth.ts Outdated Show resolved Hide resolved
LinkedIn has changed the OAuth flow by replacing it with OpenID Connect.
We have already added support for this in the backend.
@fragoulis fragoulis force-pushed the fragoulis/usr-340-js-support-the-new-linkedin-v2-oauth-provider branch from 14519a0 to c7d8425 Compare October 10, 2023 10:42
@fragoulis
Copy link
Contributor Author

fragoulis commented Oct 10, 2023

This is ready. The new provider's name will be set in dashboard, as well as whether a user can enable only one of these.

@fragoulis fragoulis added this pull request to the merge queue Oct 10, 2023
provider: 'linkedin_oidc',
strategy: 'oauth_linkedin_oidc',
name: 'LinkedIn',
docsUrl: 'https://clerk.com/docs/authentication/social-connections/linkedin-oidc',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not exist yet, right? Are we adding it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged via the queue into main with commit 9101488 Oct 10, 2023
6 checks passed
@fragoulis fragoulis deleted the fragoulis/usr-340-js-support-the-new-linkedin-v2-oauth-provider branch October 10, 2023 11:56
@clerk-cookie clerk-cookie mentioned this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants