Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-custom widget classes are translated #29

Closed
JoryHogeveen opened this issue Aug 21, 2017 · 1 comment
Closed

Non-custom widget classes are translated #29

JoryHogeveen opened this issue Aug 21, 2017 · 1 comment

Comments

@JoryHogeveen
Copy link
Collaborator

Report: https://wordpress.org/support/topic/plugin-spanish-translation/#post-9427244

The first, last, odd, even and number widgets are translated which seems a little weird. Translations are normally for text only, not for code.
Since this plugin has 90k+ users we can't just remove it. I'd say make it an option so the users can turn it off/on.

On a fresh install: Don't enable it.
On an update with the classes enabled: Enable it to prevent issues.

@cleverness
Copy link
Owner

Let's go with an option.

JoryHogeveen added a commit that referenced this issue Aug 22, 2017
@JoryHogeveen JoryHogeveen mentioned this issue Aug 22, 2017
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants