Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding a category forum by name incorrectly selects first forum with that name, regardless of category #8

Open
alexkwolfe opened this issue Jun 11, 2013 · 0 comments

Comments

@alexkwolfe
Copy link
Contributor

There is a bug in the #find_forum and #find_or_create_forum methods.

Those methods attempt to locate forum by category name and forum name. In the case where different categories have forums with the same name, then a forum from the wrong category may be returned in error.

The fix is to ensure that the forum comparison uses the category ID in addition to the forum name.

A pull request is forthcoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant