please update to latest font-awesome

[cornernote]

No description provided.

[digitalcrab]

Hello @cornernote !

Font awesome was upgraded to 4.0.3 version and committed to master branch and will be included to next release.
New icons for example: http://yii-demo.yukki.name/bootstrap/issue706

Please read carefully next information:
https://github.com/FortAwesome/Font-Awesome/wiki/Upgrading-from-3.2.1-to-4
http://fontawesome.io/whats-new/

Thank you

[kvpt]

Hello @fromYukki
Several widgets hardcode icon- prefix in icon property, the new naming convention breaks those widgets.

[digitalcrab]

Hello! @Kev360 can you give me an example? As far as i know hardcoded only bootstrap icons. Font Awesome icons can be disabled at all, and it does not affect any Yii Booster functionality.

[kvpt]

Exemple TbButton widget :
https://github.com/clevertech/YiiBooster/blob/master/src/widgets/TbButton.php#L242

[digitalcrab]

Hello @Kev360
As I said above, this applies only to icons from Bootstrap
http://getbootstrap.com/2.3.2/base-css.html#icons

If you run YiiBooster without any special settings font-awesome will be turned off, and TbButton still will be worked properly with icons from bootstrap.
Maybe you want to suggest to add the same code for fa- icon class?

[digitalcrab]

Hello @Kev360
After my last commit you can use icons as before, and in this case icons will be used from Bootstrap. Example:

        <?php $this->widget('bootstrap.widgets.TbButton', array(
            'buttonType' => 'link',
            'icon' => 'music',
            'label' => 'Bootstrap Icon',
        )); ?>

And you can use Font-Awesome icons too (in the same time). Example:

        <?php $this->widget('bootstrap.widgets.TbButton', array(
            'buttonType' => 'link',
            'icon' => 'fa fa-anchor',
            'label' => 'Font-Awesome Icon',
        )); ?>

Result: http://yii-demo.yukki.name/bootstrap/issue706

Maybe you have any other useful suggestions?
Thank you so much!

[kvpt]

Thanks !!!