Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wonderful, but inconsistent "Currently Doesn't Exist:" section #16

Closed
cspaniard opened this issue Apr 5, 2018 · 3 comments
Closed

Wonderful, but inconsistent "Currently Doesn't Exist:" section #16

cspaniard opened this issue Apr 5, 2018 · 3 comments

Comments

@cspaniard
Copy link

I am really divided on this one. I really like the "Currently Doesn't Exist:" section. However, it is only used for the "Excluded Sources:" side of things.

The "Included Sources:" section deals with missing assets in a different way.

Included Sources:

Directories:
---------------------------------------------
[...]
/lib32/ ... skipping - DOESN'T EXIST!
[...]

Files:
---------------------------------------------
/home/dsanroma/missing_file ... skipping - DOESN'T EXIST!

Where the "Excluded Sources:` section has it own section

Excluded Sources:
[...]

Currently Doesn't Exist:
---------------------------------------------
/directory with spaces/test4/ ... not on system
[...]

Furthermore, the wording and capitalization are also different " - DOESN'T EXIST!" vs "not on system".

I have no idea what I would do about this one... I just wanted to point it out. ;)

Maybe the differences could be smoothed out a little... ;)

@cleverwise
Copy link
Owner

I already changed wording to not on system for both sections in 2.3.3

The currently doesn't exist is to let the user know even though you have excluded said source it will be skipped anyway because it isn't there.

@cspaniard
Copy link
Author

I agree, and it shows in one nice list...

@cspaniard
Copy link
Author

Check -> OK as described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants