🔥 Remove unnecessary channel

cmd/dump/dump.go

@@ -115,17 +115,12 @@ func run(cmd *cobra.Command, args []string) (err error) {
 		fmt.Println("::set-output name=filename::" + filename)
 	}
 
-	ch := make(chan error, 1)
 	var w io.WriteCloser
 	switch conf.OutputFormat {
 	case sqlformat.Gzip, sqlformat.Custom:
 		w = f
-		close(ch)
 	case sqlformat.Plain:
-		w = gzips.NewDecompressWriter(f, ch)
-		if err != nil {
-			return err
-		}
+		w = gzips.NewDecompressWriter(f)
 	}
 	defer func(w io.WriteCloser) {
 		_ = w.Close()
@@ -148,12 +143,6 @@ func run(cmd *cobra.Command, args []string) (err error) {
 		return err
 	}
 
-	// Check errors in channel
-	err = <-ch
-	if err != nil {
-		return err
-	}
-
 	// Close file
 	err = f.Close()
 	if err != nil {

internal/gzips/decompress_writer.go

@@ -5,20 +5,30 @@ import (
 	"io"
 )
 
-func NewDecompressWriter(dest io.Writer, ch chan error) io.WriteCloser {
+func NewDecompressWriter(dest io.Writer) io.WriteCloser {
 	r, w := io.Pipe()
 	go func() {
+		defer func(r *io.PipeReader) {
+			_ = r.Close()
+		}(r)
+
 		gzr, err := gzip.NewReader(r)
 		if err != nil {
 			_ = r.CloseWithError(err)
 			return
 		}
-		defer func(gzr *gzip.Reader) {
-			_ = gzr.Close()
-		}(gzr)
 
 		_, err = io.Copy(dest, gzr)
-		ch <- err
+		if err != nil {
+			_ = r.CloseWithError(err)
+			return
+		}
+
+		err = gzr.Close()
+		if err != nil {
+			_ = r.CloseWithError(err)
+			return
+		}
 	}()
 	return w
 }