Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update projects depending on cli-table2 #17

Closed
schalkneethling opened this issue Jun 11, 2018 · 22 comments
Closed

Update projects depending on cli-table2 #17

schalkneethling opened this issue Jun 11, 2018 · 22 comments
Labels
good first issue Good for newcomers

Comments

@schalkneethling
Copy link
Contributor

schalkneethling commented Jun 11, 2018 •
edited by DanielRuf
Loading

We should probably use @Turbo87 message he used for npm/npm#20955 as it clearly explains the situation. I am thinking that, if you are going to open a PR against one of the repos below, open a separate issue for it, and once the PR has merged, remove it from the list here? Thoughts?

This PR updates the cli-table2 dependency to cli-table3, which fixes one of the npm audit warnings :)

cli-table2 (like cli-table itself) is no longer maintained. In jamestalmage/cli-table2#43 a couple of people have offered to take over maintenance but the current maintainer did not respond so as a result the project was forked to https://github.com/cli-table/cli-table3.
@schalkneethling schalkneethling mentioned this issue Jun 11, 2018
Open
@Turbo87
Copy link
Contributor

Turbo87 commented Jun 11, 2018

npm and npm-audit-report are already covered :)

@Turbo87
Copy link
Contributor

Turbo87 commented Jun 11, 2018

@schalkneethling I've converted the list above to checkboxes. I think we can check them already once a PR exists, because at that point there is not much we can do from our side. We might also want to add a link to the PR to make it easier to track progress.

@schalkneethling
Copy link
Contributor Author

@Turbo87 dang it, I accidentally overwrote yours :( Thought the edited revision history might give me a way to backout mine, but that did not help. Apologies for that.

@Turbo87
Copy link
Contributor

Turbo87 commented Jun 11, 2018

Fixed it 😉

@Turbo87 Turbo87 changed the title These are repos that depend on cli-table2 Update projects depending on cli-table2 Jun 11, 2018
@gsipos
Copy link

gsipos commented Jun 11, 2018 •
edited
Loading

Could you add Typescript type definitions for cli-table3?
cli-table2 has type definitions under @types/cli-table2, and the same would be sufficient for cli-table3 as well, since the api is the same.

Thanks for the PR!

@Turbo87
Copy link
Contributor

Turbo87 commented Jun 11, 2018

@gsipos see #20

@yowainwright yowainwright mentioned this issue Jun 11, 2018
Closed
@DanielRuf
Copy link
Contributor

DanielRuf commented Jun 11, 2018 •
edited
Loading

current status:
70/351
100/351

acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Jun 11, 2018
@acburdine
chore(deps): cli-table2 => cli-table3
9f787e9 
refs cli-table/cli-table3#17
- cli-table2 is unmaintained
@acburdine acburdine mentioned this issue Jun 11, 2018
Merged
@acburdine
Copy link

Ghost-CLI can be checked off the list - i'll get a release out for it sometime in the next couple of days.

@imcuttle
Copy link

Hi, Why not optimize the cli-table2 instead of publishing cli-table3

@DanielRuf
Copy link
Contributor

Hi, Why not optimize the cli-table2 instead of publishing cli-table3

The maintainer did not respond so we created an actively maintained fork.

@schalkneethling
Copy link
Contributor Author

@imcuttle You can see the threads that lead to this decision here[1] and here[2]

[1] jamestalmage/cli-table2#43
[2] jamestalmage/cli-table2#48

acburdine added a commit to TryGhost/Ghost-CLI that referenced this issue Jun 12, 2018
@acburdine
chore(deps): cli-table2 => cli-table3
134d4e1 
refs cli-table/cli-table3#17
- cli-table2 is unmaintained
@wagerfield
Copy link

eslint-index PR merged and published to NPM v1.5.0

@DanielRuf
Copy link
Contributor

DanielRuf commented Jun 16, 2018 •
edited
Loading

I cleaned up the list, removed duplicates and sorted the entries.
Now there are 351 instead of 411 packages in total.

@schalkneethling
Copy link
Contributor Author

Thanks @DanielRuf

@glorat glorat mentioned this issue Jun 24, 2018
Closed
@DanielRuf
Copy link
Contributor

Hm, seems GitHub has an issue with such long lists. Editing it will not update it anymore in most cases.

@DanielRuf
Copy link
Contributor

DanielRuf commented Jun 24, 2018 •
edited
Loading

Current list:

@schalkneethling
Copy link
Contributor Author

Yeah, I have noticed that as well. We should either prune some away or, perhaps split it up into ~4 issues, so each has a smaller list?

1 similar comment
@schalkneethling
Copy link
Contributor Author

Yeah, I have noticed that as well. We should either prune some away or, perhaps split it up into ~4 issues, so each has a smaller list?

@DanielRuf
Copy link
Contributor

Probably split it up. What do the others think?

@DanielRuf
Copy link
Contributor

bildschirmfoto 2018-06-25 um 10 31 56

But it was posted. I guess the long list and changes to it was too much for GitHub as it does not show the changes in the changes dropdown and submitting a comment takes forever.

@DanielRuf
Copy link
Contributor

👋

@DanielRuf
Copy link
Contributor

New issue: #28

I'll close this here to prevent duplicate work and keep things in sync.

@cli-table cli-table locked as resolved and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@Turbo87 @wagerfield @DanielRuf @gsipos @acburdine @schalkneethling @imcuttle