Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced table rendering performance #285

Closed
wants to merge 1 commit into from

Conversation

speedytwenty
Copy link
Collaborator

@speedytwenty speedytwenty commented Mar 31, 2022

Following the bug fix in #278, there may be a route to improving table rendering performance as per #68.

This is a first attempt at "performance tests" that attempt to:

  1. Fail for the current master
  2. Partially pass for Refactored table layouts + Layout fix for #269 #278
  3. Fully pass for fully-refactored rendering (in progress)

I did one "fixed" time test of 100k cells. Present master takes approx 72 seconds; 278 takes approx 20 seconds; and once the tests are passing they will consume less than 4 seconds.

The rest of the expectations merely check to ensure that the rendering time is not increasing substantially while a larger table is rendered after and compared with the previous rendering time.

@speedytwenty
Copy link
Collaborator Author

speedytwenty commented Mar 31, 2022

The performance tests need to be meaningful as well as reliable—I'm not sure these are reliable as they may be prone to fail and likewise do not test memory usage. I've got a solution that reliably passes these tests in the works but #278 comes much closer for now.

The efforts here should probably supersede 278 for clarity sake, but because some tests might be implicated to really refine performance I'm going to close this PR as it stands as a placeholder in time.

Please examine the failing 12.x build for "benchmarks" of these tests before performance improvements were endeavored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant