Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support bigint cell content type #340

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

ItsNickBarry
Copy link
Contributor

The existing type casting (String(value)) also works for BigInts, so I've added support in the Typescript definitions and the JS type checks.

@speedytwenty
Copy link
Collaborator

Thanks for the PR(s)! I'd like to see a supporting test that simply outputs a bigint in cell content and the resulting output is as expected. This would be more to avoid regressions when refactoring.

I'll create a new release next week. If you haven't added a test, I'll accept this as is.

@speedytwenty
Copy link
Collaborator

You'll find basic examples for issue based tests here: https://github.com/cli-table/cli-table3/tree/master/test/issues

@ItsNickBarry
Copy link
Contributor Author

Added a test. Also had to update the eslint ecmaVersion so that it could parse bigint literals.

@@ -1,6 +1,6 @@
module.exports = {
parserOptions: {
ecmaVersion: 2018,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure whether this should be considered a "breaking change". If it is, a major release still seems like overkill.

@speedytwenty
Copy link
Collaborator

Thanks for your efforts. Tests look good. Your placement of them (within cell-test.js is also better than what I suggested).

@speedytwenty speedytwenty merged commit 67e853b into cli-table:master Apr 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants