Merge pull request #897 from vilmibm/hide-review

hide stuff
cli · May 11, 2020 · aac9947 · aac9947
2 parents fe49c2d + 5695958
commit aac9947
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/command/pr_review.go b/command/pr_review.go
@@ -11,7 +11,8 @@ import (
 )
 
 func init() {
-	prCmd.AddCommand(prReviewCmd)
+	// TODO re-register post release
+	// prCmd.AddCommand(prReviewCmd)
 
 	prReviewCmd.Flags().BoolP("approve", "a", false, "Approve pull request")
 	prReviewCmd.Flags().BoolP("request-changes", "r", false, "Request changes on a pull request")

diff --git a/command/pr_review_test.go b/command/pr_review_test.go
@@ -8,6 +8,7 @@ import (
 )
 
 func TestPRReview_validation(t *testing.T) {
+	t.Skip("skipping until release is done")
 	initBlankContext("", "OWNER/REPO", "master")
 	http := initFakeHTTP()
 	for _, cmd := range []string{
@@ -22,6 +23,7 @@ func TestPRReview_validation(t *testing.T) {
 }
 
 func TestPRReview_url_arg(t *testing.T) {
+	t.Skip("skipping until release is done")
 	initBlankContext("", "OWNER/REPO", "master")
 	http := initFakeHTTP()
 	http.StubRepoResponse("OWNER", "REPO")
@@ -67,6 +69,7 @@ func TestPRReview_url_arg(t *testing.T) {
 }
 
 func TestPRReview_number_arg(t *testing.T) {
+	t.Skip("skipping until release is done")
 	initBlankContext("", "OWNER/REPO", "master")
 	http := initFakeHTTP()
 	http.StubRepoResponse("OWNER", "REPO")
@@ -112,6 +115,7 @@ func TestPRReview_number_arg(t *testing.T) {
 }
 
 func TestPRReview_no_arg(t *testing.T) {
+	t.Skip("skipping until release is done")
 	initBlankContext("", "OWNER/REPO", "feature")
 	http := initFakeHTTP()
 	http.StubRepoResponse("OWNER", "REPO")
@@ -147,6 +151,7 @@ func TestPRReview_no_arg(t *testing.T) {
 }
 
 func TestPRReview_blank_comment(t *testing.T) {
+	t.Skip("skipping until release is done")
 	initBlankContext("", "OWNER/REPO", "master")
 	http := initFakeHTTP()
 	http.StubRepoResponse("OWNER", "REPO")
@@ -156,6 +161,7 @@ func TestPRReview_blank_comment(t *testing.T) {
 }
 
 func TestPRReview_blank_request_changes(t *testing.T) {
+	t.Skip("skipping until release is done")
 	initBlankContext("", "OWNER/REPO", "master")
 	http := initFakeHTTP()
 	http.StubRepoResponse("OWNER", "REPO")
@@ -165,6 +171,7 @@ func TestPRReview_blank_request_changes(t *testing.T) {
 }
 
 func TestPRReview(t *testing.T) {
+	t.Skip("skipping until release is done")
 	type c struct {
 		Cmd           string
 		ExpectedEvent string

diff --git a/command/root.go b/command/root.go
@@ -271,7 +271,7 @@ func rootHelpFunc(command *cobra.Command, s []string) {
 		s := "  " + rpad(c.Name()+":", c.NamePadding()) + c.Short
 		if includes(coreCommandNames, c.Name()) {
 			coreCommands = append(coreCommands, s)
-		} else {
+		} else if c != creditsCmd {
 			additionalCommands = append(additionalCommands, s)
 		}
 	}