-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dry-run flag to commands #1145
Comments
I don't think we would want to add this to the non-interactive commands because we want the default behavior of those to be scriptable. For creating PRs and issues interactively, we have a "What's next" portion at the end. @AliabbasMerchant, were you thinking that we'd want an extra stage after the "What's next section"? |
No. I think that is perfect and sufficient I was referring to the non-interactive commands. A |
@billygriffin what do you think about adding the |
#1330 is a good replacement for this |
I'd like to suggest re-opening this. In particular when testing out scripts it is very useful to see exactly what a script would do without actually affecting state. For example |
I'm interested in a dry-run flag as well! Hub, for example, has the |
Quite interested in this was well. |
Would love a dry-run flag as well for the testing considerations mentioned above. For example, I just wrote a script that looped through a bunch of PRs and retargeted their base branches. It would have been good to be able to dry run the |
Thanks for all the discussion here. We have decided that we are not going to make an application wide |
Describe the feature or problem you’d like to solve
CLI is used for creating significant changes(issues, PRs, comments) in various repositories.
This may lead to inadvertent/unintended permanent changes in repositories and organisations.
Example: Inadvertently creating test PRs/Issues while testing.
Proposed solution
Either:
--dryrun
flag to commandsOR
"Do you want to make these changes? (y/n)"
And a
-y
flag, to skip this promptHow will it benefit CLI and its users?
Although it may add an extra prompt (which can be skipped via the
-y
flag), this may add a level of security/sureity as to what the intended action is, and what is occurring.Additional context
A few of the recent fake/test PRs/Issues/Comments we have received may have been inadvertent
(Happened with me twice 😓 Thankfully, was able to convert them into something useful)
This would be a potentially huge change, and would require lots of investment in terms of time
The text was updated successfully, but these errors were encountered: