Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation steps to risky write commands #1330

Closed
ampinsk opened this issue Jul 6, 2020 · 3 comments · Fixed by #1706
Closed

Add confirmation steps to risky write commands #1330

ampinsk opened this issue Jul 6, 2020 · 3 comments · Fixed by #1706
Labels
enhancement a request to improve CLI

Comments

@ampinsk
Copy link
Contributor

ampinsk commented Jul 6, 2020

Right now, we have a few commands that we should ask the user to confirm before proceeding when using in a terminal.

  • gh pr create (when creating fork)
  • gh repo create
  • gh pr merge
  • gh repo fork (?)

A first pass at design:

Screen Shot 2020-07-06 at 9 43 43 AM

Let me know if there are other commands that we should include here!

@ampinsk ampinsk created this issue from a note in The GitHub CLI (Backlog 🗒) Jul 6, 2020
@vilmibm vilmibm added the enhancement a request to improve CLI label Jul 9, 2020
@vilmibm
Copy link
Contributor

vilmibm commented Jul 9, 2020

thanks for opening this!

@ShubhankarKG
Copy link
Contributor

#1357 has a fix for gh repo create and gh pr merge. It'll be better if someone else can take up the other two commands, viz. gh pr create and gh repo fork

@AliabbasMerchant
Copy link
Contributor

Great! I will take up the other two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement a request to improve CLI
Projects
No open projects
The GitHub CLI
  
Done 💤
Development

Successfully merging a pull request may close this issue.

4 participants