Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move survey helper and test helpers to prompt pkg #1436

Merged
merged 1 commit into from
Jul 28, 2020
Merged

move survey helper and test helpers to prompt pkg #1436

merged 1 commit into from
Jul 28, 2020

Conversation

vilmibm
Copy link
Contributor

@vilmibm vilmibm commented Jul 27, 2020

This PR contains no functional changes; it's just a move of SurveyAsk and the AskStubber out of
the command package and into the new prompt package.

This allows this code to be used by both new-style and old style commands without copypasta.

@vilmibm vilmibm added this to Backlog 🗒 in The GitHub CLI via automation Jul 27, 2020
@vilmibm vilmibm requested a review from mislav July 27, 2020 22:01
@vilmibm vilmibm moved this from Backlog 🗒 to Needs review 🤔 in The GitHub CLI Jul 27, 2020
The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Jul 28, 2020
mislav
mislav approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@vilmibm vilmibm merged commit 43318fd into trunk Jul 28, 2020
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Jul 28, 2020
@mislav mislav deleted the move-ask-stubber branch August 3, 2020 08:01
@mislav mislav moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mislav mislav mislav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vilmibm @mislav