Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate remaining old-style commands #1500

Merged
merged 13 commits into from
Aug 12, 2020
Merged

Isolate remaining old-style commands #1500

merged 13 commits into from
Aug 12, 2020

Conversation

mislav
Copy link
Contributor

@mislav mislav commented Aug 7, 2020

Isolated issue and other remaining commands to their own packages. This resulted in a major cleanup in the old command/root.go and context package. 馃

Fixes #759

TODO:

  • port over alias commands and we're done!

@mislav mislav requested a review from vilmibm August 7, 2020 15:00
@mislav mislav added this to Needs review 馃 in The GitHub CLI Aug 7, 2020
The GitHub CLI automation moved this from Needs review 馃 to Needs to be merged 馃帀 Aug 7, 2020
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much for all this ;_;

pkg/cmd/issue/create/create.go Show resolved Hide resolved
Base automatically changed from pr-commands-isolate-3 to trunk August 11, 2020 13:40
@mislav mislav requested a review from vilmibm August 11, 2020 13:42
@mislav
Copy link
Contributor Author

mislav commented Aug 11, 2020

@vilmibm I've also ported alias commands and expansion since you've last reviewed. Please take a look!

Note that additional auth commands are now to be added in pkg/cmd/auth/auth.go instead of to command/root.go

Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alias port looks great and i'm excited for the root reorganization

@mislav mislav merged commit 291cded into trunk Aug 12, 2020
The GitHub CLI automation moved this from Needs to be merged 馃帀 to Pending Release 馃 Aug 12, 2020
@mislav mislav deleted the issue-commands-isolate branch August 12, 2020 10:35
@github-actions github-actions bot moved this from Pending Release 馃 to Done 馃挙 in The GitHub CLI Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
The GitHub CLI
  
Done 馃挙
Development

Successfully merging this pull request may close these issues.

Improve test isolation when exercising Cobra commands
2 participants