properly check for tty when in powershell #1607
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1581
Only under Powershell we were failing to accurately tell if a command was running attached to a tty or not due to our use of colorableOut. This PR
tweaks the check to account for thisbackports a change made in #1552 that cached the isTerminal check prior to creating a colorable, avoiding the bug.I had to do a gross hack to fix this and am open to suggestion.colorable
only builds thecolorable.Writer
type if built on windows; this made detecting the above scenario very difficult. I had to make a shim type that is conditionally built in order to get this compiling on all of our CI test nodes.