Do not html escape repo view output #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcoe
force-pushed
the
fix-repo-view-bug
branch
from
1bf38e7
to
12f2724
Compare
mislav
suggested changes
Sep 10, 2020
samcoe
force-pushed
the
fix-repo-view-bug
branch
from
12f2724
to
762ad14
Compare
samcoe
force-pushed
the
fix-repo-view-bug
branch
from
762ad14
to
e50833c
Compare
mislav
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug where
repo viewwas HTML escaping its output. The fix was to change from usinghtml/templatepackage totext/templatepackage which does not do any sort of escaping.https://golang.org/pkg/text/template/
Before:
After:
cc https://github.com/github/client-apps/discussions/23#discussioncomment-75188