New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1190 - limit merge methods #2224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thank you for spiking this out. We can look into how to best update the test. 🙇
@divbhasin Thanks for your contribution. I went ahead and merged in the latest trunk, updated some of the functionality to properly handle when a repository does not have all merge options available, and cleaned up the tests a bit. It should be good to go now 🥳 |
Fix #1190. I plan to address the bonus points mentioned in the issue but the trouble I am having is how to modify the
TestPRMerge_interactive
(in /pkg/cmd/pr/merge/merge_test.go) to work with this modified code. The repoREPO
we use to test does not have any of the 3 options enabled, so the prompt never appears and the 2nd HTTP stub does not get matched. How do I make sure that at the time REPO is created, it is created with at least 1 of the merge PR options?