Prompt: avoid resetting PR/issue metadata #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiand391
changed the title
mislav
reviewed
Dec 2, 2020
pkg/cmd/pr/shared/survey.go
Outdated
| } | ||
|
|
||
| state.MetadataResult = nil |
There was a problem hiding this comment.
At first I wasn't clear why you did this, but then I tested it out and noticed that it fails in AddMetadataToIssueParams without this line.
I'm not convinced of this workaround, though, because it clears the cache of what was just fetched from the server and causes a whole bunch of records to be fetched again. I realize that fixing this properly is non-trivial, and I don't require that you add it to your PR. I'm currently exploring alternatives.
For metadata types chosen in interactive flow, we fetch all records from the API in order to be able to display a multi-select interface. For metadata defined via command-line flags, we resolve records that can be looked up directly, avoiding fetching the entirety of expensive datasets (e.g. all members of an organization) if we can. The new approach ensures efficient fetching when interactive flow is combined with values from flags.
mislav
approved these changes
Dec 3, 2020
samcoe
approved these changes
Dec 3, 2020
|
api/queries_repo.go |
kobk372
pushed a commit
to kobk372/cli
that referenced
this pull request
Dec 13, 2020
Prompt: avoid resetting PR/issue metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2369
Fixes #2475
The current implementation of
MetadataSurveyresets metadata provided by flags if no option is selected (pressEnterwithout selecting anything) and when the user adds metadata in the prompt.This happens because Survey doesn't return an error if you pass an empty slice of questions to it, so this check pass and
statemetadata fields are assigned tonilafter that.This PR contains the following changes:
mqsis empty before sending it to surveymqsisn't empty, fillvalueswith the values ofstate, that way it'll preserve metadata passed by flags.state.MetadataResultto nilThis is needed because
MetadataSurveysetsstate.MetadataResultto the selected options here, but if the user doesn't select anything or adds metadata thenAddMetadataToIssueParamsfails the get the IDs. By setting it tonilit'll be properly filled here.Demo: