Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve completion docs for bash, zsh, fish #2636

Merged
merged 1 commit into from Dec 17, 2020
Merged

Improve completion docs for bash, zsh, fish #2636

merged 1 commit into from Dec 17, 2020

Conversation

mislav
Copy link
Contributor

@mislav mislav commented Dec 16, 2020 •
edited

Fixes #2515, fixes #716

vilmibm
vilmibm approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful, thank you

@vilmibm vilmibm added this to Backlog 🗒 in The GitHub CLI via automation Dec 16, 2020
@vilmibm vilmibm moved this from Backlog 🗒 to Needs to be merged 🎉 in The GitHub CLI Dec 16, 2020
@mislav mislav merged commit 782932b into trunk Dec 17, 2020
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Dec 17, 2020
@mislav mislav deleted the docs-completion branch December 17, 2020 17:21
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vilmibm vilmibm vilmibm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.1.0 update to 1.3.0 zsh autocomplete failed Document oh-my-zsh workaround for completion support
2 participants
@mislav @vilmibm