Comment on pull requests #2776
Merged
Comment on pull requests #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
reviewed
Jan 13, 2021
There was a problem hiding this comment.
Is there a chance we could reuse the same code, since everything is identical about leaving a comment to an issue vs. the PR?
I worry that this might not be just incidental duplication: we might need to maintain the commenting code, and it might be tricky to remember to duplicate all changes in two places, especially for outside contributors.
|
@mislav I went ahead and refactored this to clean up the duplicate code and hopefully make it easier to maintain both comment commands in the future. It seemed like there were a couple different ways to go about this refactor so let me know if you had any other thoughts on it 🙇 |
mislav
suggested changes
Jan 15, 2021
mislav
approved these changes
Jan 21, 2021
- "Press Enter" is both bold - "Enter" is capitalized - The prompt ends with "..."
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for commenting on pull requests. The commenting code for issues and pull requests was very similar so I refactored to extract the
commentable.gofile which contains the shared functionality.Additionally after talking with @ampinsk we decided that the initial input type survey was not serving much of a purpose and we decided to replace it with the standard editor survey that prompts the user to open their editor.
closes #517