Add fail message for non-existent hostname

[n1lesh]

Fixes #2775.

[mislav]

Thank you! The error message text needs changing, though.

Did you consider also making a test in status_test.go?

[mislav]

We already print this message above:

cli/pkg/cmd/auth/status/status.go

Lines 71 to 74 in 4750e4a

	if len(hostnames) == 0 || err != nil {
	fmt.Fprintf(stderr,
	"You are not logged into any GitHub hosts. Run %s to authenticate.\n", cs.Bold("gh auth login"))
	return cmdutil.SilentError

The message you added here isn't accurate for the condition we're testing. The issue you've set to fix is to warn that a hostname passed via the -h argument wasn't found. How about something like this?

"Hostname %q not found among authenticated GitHub hosts"

[n1lesh]

@mislav It seems that the code in status_test.go silently ignores the stderr message in favour of wantErr.

cli/pkg/cmd/auth/status/status_test.go

Lines 239 to 243 in 4750e4a

	assert.Equal(t, tt.wantErr == nil, err == nil)
	if err != nil {
	if tt.wantErr != nil {
	assert.True(t, tt.wantErr.MatchString(err.Error()))
	return

Since we return SilentError we have to make wantErr non-nil, and that forces condition on L241 to occur, thus pre-maturely returning, avoiding a check on wantErrOut. Any suggestions around this?

[mislav]

This looks good! Thank you.

[vilmibm]

@samcoe to fix conflicts and merge