Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete unused parameter #2809

Merged
merged 1 commit into from Jan 21, 2021
Merged

delete unused parameter #2809

merged 1 commit into from Jan 21, 2021

Conversation

vilmibm
Copy link
Contributor

@vilmibm vilmibm commented Jan 20, 2021

tiny PR deleting some dead code i noticed

@vilmibm vilmibm requested review from mislav and samcoe January 20, 2021 03:09
@vilmibm vilmibm added this to Backlog 🗒 in The GitHub CLI via automation Jan 20, 2021
@vilmibm vilmibm moved this from Backlog 🗒 to Needs review 🤔 in The GitHub CLI Jan 20, 2021
mislav
mislav approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Would we consider enabling the unparam linter that catches cases like these?

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Jan 20, 2021
@samcoe samcoe merged commit 938f6f4 into trunk Jan 21, 2021
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Jan 21, 2021
@samcoe samcoe deleted the deadcode branch January 21, 2021 17:56
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mislav mislav mislav approved these changes

@samcoe samcoe samcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vilmibm @mislav @samcoe