Update notifier: avoid false positives when gh is built from source #2812
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When gh was built from source, the version number will look something like this since it's taken from
git describe
:When compared as semver against
v1.4.0
, the latter version is falsely reported as newer. This is because the output ofgit describe
wasn't meant to be interpreted as semver.The solution is to translate the
git describe
string to faux-semver so it can be safely compared with the version reported from the server.Fixes this case: