Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secret set --repos for repositories that have dashes #2844

Merged
merged 1 commit into from Jan 25, 2021

Conversation

mislav
Copy link
Contributor

@mislav mislav commented Jan 25, 2021

A GraphQL alias cannot contain dashes. Instead, generate safe identifiers for GraphQL aliases.

Fixes #2829

A GraphQL alias cannot contain dashes. Instead, generate safe
identifiers for GraphQL aliases.
@mislav mislav requested a review from vilmibm January 25, 2021 19:27
@vilmibm vilmibm added this to Backlog 🗒 in The GitHub CLI via automation Jan 25, 2021
@vilmibm vilmibm moved this from Backlog 🗒 to Needs review 🤔 in The GitHub CLI Jan 25, 2021
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Jan 25, 2021
@vilmibm vilmibm merged commit e9afac9 into trunk Jan 25, 2021
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Jan 25, 2021
@vilmibm vilmibm deleted the secret-set-fix branch January 25, 2021 19:35
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
The GitHub CLI
  
Done 💤
Development

Successfully merging this pull request may close these issues.

gh secret set fails if repository name contains '-' with 'GraphQL error: Parse error on "-"'
2 participants