Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Branch Up to Date Status #2952

Merged
merged 4 commits into from Feb 16, 2021
Merged

Adds Branch Up to Date Status #2952

merged 4 commits into from Feb 16, 2021

Conversation

redreceipt
Copy link
Contributor

@redreceipt redreceipt commented Feb 11, 2021

This shows whether the current head branch is behind the base branch similar to the web GUI.

Screen Shot 2021-02-11 at 4 25 26 PM

Uses the preview API here: https://docs.github.com/en/graphql/reference/enums#mergestatestatus

Closes #2945

Copy link
Contributor

@billygriffin billygriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @redreceipt! I think we should conditional this based on whether the setting you referenced in your issue is checked. If it's not a blocker to merging, I don't think it deserves the same level of prominence that checks status and approval status do. Thoughts on making this only display for repos that require a branch to be up to date prior to merging?

@redreceipt
Copy link
Contributor Author

Yea I think I agree. Hopefully, the API has that info 😂

@redreceipt
Copy link
Contributor Author

ok @billygriffin take a look at this

@samcoe samcoe added this to Backlog 🗒 in The GitHub CLI via automation Feb 12, 2021
@samcoe samcoe moved this from Backlog 🗒 to Needs review 🤔 in The GitHub CLI Feb 12, 2021
@billygriffin billygriffin requested review from a team and removed request for billygriffin February 16, 2021 03:19
The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Feb 16, 2021
@vilmibm vilmibm merged commit c2c211d into cli:trunk Feb 16, 2021
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Feb 16, 2021
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
The GitHub CLI
  
Done 💤
Development

Successfully merging this pull request may close these issues.

PR Status Should Show Branch Not Up To Date
3 participants