Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize the write:org OAuth scope as satisfying read:org #2965

Merged
merged 2 commits into from Feb 17, 2021

Conversation

mislav
Copy link
Contributor

@mislav mislav commented Feb 15, 2021

If someone pastes a PAT with write:org scope, this avoids the error complaining that the token doesn't have read:org permissions. On GitHub, write:org implies read:org.

From #1941 (comment)

If someone pastes a PAT with `write:org` scope, this avoids the error
complaining that the token doesn't have `read:org` permissions. On
GitHub, `write:org` implies `read:org`.
@mislav mislav requested a review from a team February 15, 2021 16:57
@mislav mislav added this to Backlog 🗒 in The GitHub CLI via automation Feb 15, 2021
@mislav mislav moved this from Backlog 🗒 to Needs review 🤔 in The GitHub CLI Feb 15, 2021
The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Feb 16, 2021
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@mislav mislav merged commit faa6981 into trunk Feb 17, 2021
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Feb 17, 2021
@mislav mislav deleted the writeorg-oauth-scope branch February 17, 2021 16:26
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
The GitHub CLI
  
Done 💤
Development

Successfully merging this pull request may close these issues.

None yet

3 participants