Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include issue number alongside the title in gh issue/pr view #3741

Merged
merged 5 commits into from
Jun 2, 2021
Merged

Include issue number alongside the title in gh issue/pr view #3741

merged 5 commits into from
Jun 2, 2021

Conversation

Jackenmen
Copy link
Contributor

Should fix #3729

@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI May 28, 2021
@Jackenmen Jackenmen changed the title Update formatting Include PR number alongside the title in gh pr view May 29, 2021
@Jackenmen
Copy link
Contributor Author

Jackenmen commented May 29, 2021 •
edited

I just realized I forgot about gh issue view, should I include such a change in this PR as well?

Edit: went ahead and did that, let me know if you want me to split it into another PR as it should just a matter of cherry-picking because each individual commit should work properly on its own.

@Jackenmen Jackenmen changed the title Include PR number alongside the title in gh pr view Include PR number alongside the title in gh issue/pr view May 29, 2021
@Jackenmen Jackenmen changed the title Include PR number alongside the title in gh issue/pr view Include issue number alongside the title in gh issue/pr view May 29, 2021
@vilmibm vilmibm self-requested a review June 1, 2021 20:43
vilmibm
vilmibm suggested changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! just gotta fix that missing newline

pkg/cmd/issue/view/view.go Outdated Show resolved Hide resolved
Jackenmen
Jackenmen commented Jun 1, 2021
View reviewed changes
Copy link
Contributor Author

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this comment, just preparing the code suggestions to merge into the PR's branch.

pkg/cmd/issue/view/view.go Outdated Show resolved Hide resolved
pkg/cmd/pr/view/view.go Outdated Show resolved Hide resolved
@Jackenmen
Copy link
Contributor Author

I've noticed that there were some conflicts so I resolved them too. This should be ready to go now.

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Jun 2, 2021
vilmibm
vilmibm approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thank you~

@vilmibm vilmibm merged commit a1cedfc into cli:trunk Jun 2, 2021
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Jun 2, 2021
@Jackenmen Jackenmen deleted the patch-1 branch June 2, 2021 18:53
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vilmibm vilmibm vilmibm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include PR number at the top of gh pr view's output
2 participants
@Jackenmen @vilmibm