Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for XDG_DATA_HOME #3768

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Add support for XDG_DATA_HOME #3768

merged 2 commits into from
Jun 2, 2021

Conversation

samcoe
Copy link
Contributor

@samcoe samcoe commented Jun 2, 2021

This PR introduces support for XDG_DATA_HOME to store data files. Since we don't currently have any data files stored there is no migration code. It also documents the new XDG environment variables in the environment help topic.

cc #2470
cc #554
closes #3712

@samcoe samcoe self-assigned this Jun 2, 2021
@samcoe samcoe marked this pull request as ready for review June 2, 2021 13:59
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Jun 2, 2021
@samcoe samcoe requested a review from a team June 2, 2021 14:00
The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Jun 2, 2021
@samcoe samcoe merged commit 7388d1e into trunk Jun 2, 2021
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Jun 2, 2021
@samcoe samcoe deleted the xdg-data branch June 2, 2021 17:40
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
The GitHub CLI
  
Done 💤
Development

Successfully merging this pull request may close these issues.

GH_CONFIG_DIR is missing in gh help environment
2 participants