Extract concepts of local and remote git repos #4900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a concept of a Git object that is asked for git operations (only Push for now) from the context of a command. Instead of stubbing out the `git push` command, the call to `Push()` itself is stubbed via mock object generated by mockery. Additionally, this introduces tests that exercise the logic of shelling out to `git push`, which is now rewritten to ensure synchronous I/O.
The `browse` command queries the GitClient object it received for information like "LastCommit" and "PathPrefix". Depending on the `--repo` flag, the repository queried will be either the local git repository (normal case) or the remote git repository via the GitHub API (in case of the repo override). Each git query method now supports passing a `context.Context` object to support cancellation at a lower level.
|
Hey thanks for moving forward with the prototype, I'm looking forward to seeing how this turns out. Just in case you didn't see it, I suggested that the Maybe this can be added into this pr for a better experience, especially now that the last commit can come from two different sources. |
Ah, thanks for reminding me. I missed that comment. I will make sure to address it in this PR 👍 |
|
i like this idea~ thanks for working on it |
1 task
2 tasks
|
Superseded by #6354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
browsecommand queries the GitClient object it received for information like "LastCommit" and "PathPrefix". Depending on the--repoflag, the repository queried will be either the local git repository (normal case) or the remote git repository via the GitHub API (in case of the--repooverride).This is a followup to #4845 by @bchadwic with the goal of extracting and exposing concepts like a "local git repo" and "remote git repo" behind a unified interface. This will be useful for all commands that support the
--repooverride and need access to git information.Design goals:
context.Contextobject to support cancellation at a lower level.TODO:
git.*WithPath()methodsremoterepo.Clientgains access to*http.Clientandghrepo.Interface- ideally it wouldn't rely on passing funcs around anymoregit.*methods as deprecated - all future queries should go through an instantiated client