Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore FORBIDDEN errors for gh status #5588

Merged
merged 3 commits into from May 10, 2022
Merged

Ignore FORBIDDEN errors for gh status #5588

merged 3 commits into from May 10, 2022

Conversation

heaths
Copy link
Contributor

@heaths heaths commented May 8, 2022 •
edited

Fixes #5587. Also hides progress indicator if an errors occurs.

@heaths heaths requested a review from a team as a code owner May 8, 2022 19:32
@heaths heaths requested review from mislav and removed request for a team May 8, 2022 19:32
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label May 8, 2022
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI May 8, 2022
@heaths heaths mentioned this pull request May 9, 2022
Merged
@heaths
Copy link
Contributor Author

heaths commented May 9, 2022

Used similar wording to both the GraphQL error message as well as prescriptive advice based on some other commands.

mislav
mislav approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've pushed additions to optimize some related fetches for speed, improve error handling, and ensure that the URL reported in X-GitHub-SSO header is printed so that the user might do the SAML dance without having to gh auth refresh.

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 May 10, 2022
@mislav mislav enabled auto-merge May 10, 2022 13:48
@mislav mislav merged commit f309982 into cli:trunk May 10, 2022
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 May 10, 2022
@heaths heaths deleted the issue5587 branch May 10, 2022 14:31
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mislav mislav mislav approved these changes

Assignees
No one assigned
Labels
external pull request originating outside of the CLI core team
Projects
No open projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot gh status when SAML enforcement required and not authorized
3 participants
@heaths @mislav @cliAutomation