pr checks: avoid deduplicating same-named checks under different workflows #5919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilmibm
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
Looks good!
Since workflow name is an important piece of checks information that we previously omitted from gh pr checks output, should we consider prepending the workflow name to checks name, like the web interface already does? This could be either in this PR or as follow-up.
I'm in favor of this. It's up to you if you want to do it now or in a follow-up.
samcoe
reviewed
Jul 12, 2022
api/export_pr_test.go
Outdated
| @@ -9,6 +9,8 @@ import ( | |||
| "github.com/MakeNowJust/heredoc" | |||
| "github.com/stretchr/testify/assert" | |||
| "github.com/stretchr/testify/require" | |||
| diff "github.com/yudai/gojsondiff" | |||
There was a problem hiding this comment.
It seems a bit heavy handed to require a new library just for a single test... I am wondering if there is an easier way to make the same assertions without requiring adding a whole new library to the project? Additionally, the library doesn't seem to be actively maintained which is a bit concerning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our checks de-duplication logic was a bit too overzealous in a way that it would squash same-named checks coming from different workflows under the same entry in
gh pr checksoutput.Bonus: this also adds
workflowNamefor Checks andstartedAtfor Statuses ingh pr view --json statusCheckRollupoutput.Fixes #5898
TODO:
gh pr checksoutput, should we consider prepending the workflow name to checks name, like the web interface already does? This could be either in this PR or as follow-up.