Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly determine run started/elapsed timestamps #5945

Merged
merged 4 commits into from
Jul 21, 2022
Merged

Conversation

mislav
Copy link
Contributor

@mislav mislav commented Jul 14, 2022

This switches run list and run view commands to measure how long ago did the run happen by using run_started_at, which is the timestamp of the latest run in a series, instead of created_at, which is the timestamp of the first run.

Fixes #5931
Most likely fixes #5629

This switches `run list` and `run view` commands to measure how long ago
did the run happen by using `run_started_at`, which is the timestamp of
the latest run in a series, instead of `created_at`, which is the
timestamp of the first run.
@mislav mislav requested a review from a team as a code owner July 14, 2022 17:33
@mislav mislav requested review from samcoe and removed request for a team July 14, 2022 17:33
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Jul 14, 2022
This switches `run list` and `run view` commands to measure how long ago
did the run happen by using `run_started_at`, which is the timestamp of
the latest run in a series, instead of `created_at`, which is the
timestamp of the first run.
@mislav mislav requested a review from vilmibm July 20, 2022 18:39
The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Jul 20, 2022
@mislav mislav merged commit 02881b4 into trunk Jul 21, 2022
@mislav mislav deleted the run-started-fix branch July 21, 2022 15:30
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Jul 21, 2022
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
The GitHub CLI
  
Done 💤
Development

Successfully merging this pull request may close these issues.

gh run list has incorrect "elapsed" values gh run view - only first attempt
2 participants