Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add header to the gpg-key list output #6353

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Add header to the gpg-key list output #6353

merged 1 commit into from
Sep 28, 2022

Conversation

nsmag
Copy link
Contributor

@nsmag nsmag commented Sep 27, 2022

As discussed in #6332.

Add header to the gpg-key list output:

$ gh gpg-key list
EMAIL                               KEY ID            PUBLIC KEY     ADDED  EXPIRES
name@domain.com                     3AA5C34371567FOO  xxxxx...xxxxx  1d     Never
name1@domain.com, name2@domain.com  3AA5C34371567BAR  xxxxx...xxxxx  1d     2023-01-01

There's no changes in non interactive mode.

@nsmag nsmag requested a review from a team as a code owner September 27, 2022 12:30
@nsmag nsmag requested review from mislav and removed request for a team September 27, 2022 12:30
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Sep 27, 2022
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Sep 27, 2022
@nsmag nsmag mentioned this pull request Sep 27, 2022
Closed
4 tasks
@samcoe samcoe self-assigned this Sep 28, 2022
samcoe
samcoe approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Sep 28, 2022
@samcoe samcoe merged commit ed9361f into cli:trunk Sep 28, 2022
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Sep 28, 2022
@nsmag nsmag deleted the enhance-gpg-list branch September 28, 2022 07:48
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcoe samcoe samcoe approved these changes

@mislav mislav Awaiting requested review from mislav mislav is a code owner automatically assigned from cli/code-reviewers

Assignees

@samcoe samcoe

Labels
external pull request originating outside of the CLI core team
Projects
No open projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nsmag @samcoe @cliAutomation