Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to pr merge allowing the selection of the merge commit email #6382

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

aacoakley
Copy link

Fixes: #1450

pr merge lacked the ability to specify which email tied to your account is used to for merging commits. I added an --author-email flag to take in an email string to be used to populate the graphql field authorEmail. Otherwise the field is left blank and the merge commit uses your default email.

I tested this on my own private repo to avoid leaking my personal emails to the public. It's worth noting that if you have settings configured to hide your personal email, Github will use your masked noreply email regardless of the email used here.

@aacoakley aacoakley marked this pull request as ready for review October 1, 2022 17:35
@aacoakley aacoakley requested a review from a team as a code owner October 1, 2022 17:35
@aacoakley aacoakley requested review from mislav and removed request for a team October 1, 2022 17:35
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Oct 1, 2022
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Oct 1, 2022
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, nice work!

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Oct 4, 2022
@vilmibm vilmibm enabled auto-merge October 4, 2022 19:42
@vilmibm vilmibm merged commit 9e7a6eb into cli:trunk Oct 4, 2022
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Oct 4, 2022
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Oct 4, 2022
@aacoakley aacoakley deleted the merge-author-email-flag branch October 5, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external pull request originating outside of the CLI core team
Projects
No open projects
The GitHub CLI
  
Done 💤
Development

Successfully merging this pull request may close these issues.

Select commit email when merging PR
3 participants