Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support explicitly marking a Release as "Latest" #6538

Merged
merged 1 commit into from Nov 3, 2022
Merged

Support explicitly marking a Release as "Latest" #6538

merged 1 commit into from Nov 3, 2022

Conversation

mislav
Copy link
Contributor

@mislav mislav commented Oct 31, 2022

@mislav mislav requested a review from a team as a code owner October 31, 2022 15:33
@mislav mislav requested review from vilmibm and removed request for a team October 31, 2022 15:33
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Oct 31, 2022
samcoe
samcoe reviewed Nov 1, 2022
View reviewed changes
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely this mark_latest param does not exist on GHES yet... do we want to do some sort of feature gating there? Otherwise code looks good to me.

@mislav
Copy link
Contributor Author

mislav commented Nov 2, 2022

Likely this mark_latest param does not exist on GHES yet... do we want to do some sort of feature gating there?

Good point, but we can't feature-detect support for incoming POST parameters on GHES, so I'd say let's just ship this and have it be a no-op on current and older GHES.

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Nov 2, 2022
@mislav mislav merged commit 6c8aaff into trunk Nov 3, 2022
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Nov 3, 2022
@mislav mislav deleted the release-make-latest branch November 3, 2022 10:31
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcoe samcoe samcoe approved these changes

@vilmibm vilmibm Awaiting requested review from vilmibm vilmibm is a code owner automatically assigned from cli/code-reviewers

Assignees

@mislav mislav

Labels
None yet
Projects
No open projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to mark a GitHub release as "Latest"
2 participants
@mislav @samcoe