Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix signing Windows exe on release #6776

Merged
merged 1 commit into from Dec 22, 2022
Merged

Fix signing Windows exe on release #6776

merged 1 commit into from Dec 22, 2022

Conversation

mislav
Copy link
Contributor

@mislav mislav commented Dec 22, 2022 •
edited

The osslsigncode-powered step would fail on Ubuntu 22 runners because osslsigncode would complain about the PFX certificate (or its password) being invalid. The downgrade to Ubuntu 20 fixes this for now.

Failed to parse PKCS#12 file: /tmp/cert.Ixj (Wrong password?)
006E50B99E7F0000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:../crypto/evp/evp_fetch.c:349:Global default library context, Algorithm (RC2-40-CBC : 0), Properties ()

https://github.com/cli/cli/actions/runs/3760731507/jobs/6391765553

@mislav mislav requested a review from a team as a code owner December 22, 2022 20:58
@mislav mislav requested review from vilmibm and removed request for a team December 22, 2022 20:58
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Dec 22, 2022
The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Dec 22, 2022
@mislav mislav merged commit 7ffa87f into trunk Dec 22, 2022
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Dec 22, 2022
@mislav mislav deleted the goreleaser-fix branch December 22, 2022 21:07
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vilmibm vilmibm vilmibm approved these changes

Assignees

@mislav mislav

Labels
None yet
Projects
No open projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mislav @vilmibm