Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make a commit on extension create #6833

Merged
merged 3 commits into from Jan 24, 2023
Merged

make a commit on extension create #6833

merged 3 commits into from Jan 24, 2023

Conversation

mntlty
Copy link
Collaborator

@mntlty mntlty commented Jan 10, 2023 •
edited

Closes #6795

  1. Makes a commit with the message "initial commit" for each of
  • go binary
  • other binary
  • script
    type extensions.
  1. Adds an extra message to the output indicating that a commit was made
  2. Changes the command output to say "run" instead of "use" for consistency

Note that the issue states that

The commit operation should be non-fatal in case something in the user's git config makes the commit fail.

I understood this to mean that if an error occurs making the commit, we should not fail extension creation.

@mntlty mntlty marked this pull request as ready for review January 10, 2023 08:04
@mntlty mntlty requested a review from a team as a code owner January 10, 2023 08:04
@mntlty mntlty requested review from mislav and removed request for a team January 10, 2023 08:04
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Jan 10, 2023
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Jan 10, 2023
mislav
mislav approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Error handling looks good

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Jan 24, 2023
@mislav mislav merged commit a231b4a into trunk Jan 24, 2023
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Jan 24, 2023
@mislav mislav deleted the mntlty/extension_commit branch January 24, 2023 16:48
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mislav mislav mislav approved these changes

Assignees
No one assigned
Labels
external pull request originating outside of the CLI core team
Projects
No open projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate commit and push in gh extension create output
3 participants
@mntlty @mislav @cliAutomation