Migrate search commands to new table printer and add headers #6869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
approved these changes
Jan 18, 2023
| @@ -106,7 +106,7 @@ func TestSearchIssues(t *testing.T) { | |||
| }, | |||
| }, | |||
| }, | |||
| wantStdout: "test/cli\t123\topen\tsomething broken\tbug, p1\t2021-02-28 12:30:00 +0000 UTC\nwhat/what\t456\tclosed\tfeature request\tenhancement\t2021-02-28 12:30:00 +0000 UTC\nblah/test\t789\topen\tsome title\t\t2021-02-28 12:30:00 +0000 UTC\n", | |||
| wantStdout: "test/cli\t123\topen\tsomething broken\tbug, p1\t2021-02-28T12:30:00Z\nwhat/what\t456\tclosed\tfeature request\tenhancement\t2021-02-28T12:30:00Z\nblah/test\t789\topen\tsome title\t\t2021-02-28T12:30:00Z\n", | |||
There was a problem hiding this comment.
Nice that machine-readable timestamps are now in standardized format 🎉
It's a backwards-incompatible change, though; we should note that in the release notes.
| @@ -188,7 +188,7 @@ func TestReposRun(t *testing.T) { | |||
| }, | |||
| }, | |||
| tty: true, | |||
| wantStdout: "\nShowing 3 of 300 repositories\n\ntest/cli of course private, archived Feb 28, 2021\ntest/cliing wow public, fork Feb 28, 2021\ncli/cli so much internal Feb 28, 2021\n", | |||
There was a problem hiding this comment.
Interesting how in tty mode, these timestamps switched from being absolute to being relative about 1 year ago?
There was a problem hiding this comment.
Yeah in tty mode these timestamps changed from using FuzzyAgoAbbr to FuzzyAgo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the search commands to use the new table printer and also adds headers to the TTY output of the search commands.