Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename --confirm flag to --yes for various destructive commands #6915

Merged
merged 7 commits into from Jan 26, 2023
Merged

Rename --confirm flag to --yes for various destructive commands #6915

merged 7 commits into from Jan 26, 2023

Conversation

damiensedgwick
Copy link
Contributor

Fixes #6892

As per the discussions in the issue. This PR addresses the additional commands that uses the --confirm flag and marks it as deprecated in favour of --yes

@damiensedgwick damiensedgwick marked this pull request as ready for review January 25, 2023 18:24
@damiensedgwick damiensedgwick requested a review from a team as a code owner January 25, 2023 18:24
@damiensedgwick damiensedgwick requested review from vilmibm and removed request for a team January 25, 2023 18:24
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Jan 25, 2023
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Jan 25, 2023
@damiensedgwick damiensedgwick changed the title Fix/#6892 update confirmation flags for remaining use cases Extends fix for #6892 by updating the remaining confirmation flags Jan 25, 2023
mislav
mislav approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you very much.

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Jan 26, 2023
@mislav mislav changed the title Extends fix for #6892 by updating the remaining confirmation flags Rename --confirm flag to --yes for various destructive commands Jan 26, 2023
@mislav mislav merged commit bab1b00 into cli:trunk Jan 26, 2023
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Jan 26, 2023
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mislav mislav mislav approved these changes

@vilmibm vilmibm Awaiting requested review from vilmibm vilmibm is a code owner automatically assigned from cli/code-reviewers

Assignees
No one assigned
Labels
external pull request originating outside of the CLI core team
Projects
No open projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gh repo delete --confirm is confusingly named
3 participants
@damiensedgwick @mislav @cliAutomation