-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add issue create --editor
#7193
base: trunk
Are you sure you want to change the base?
Conversation
c6b72c9
to
b24cdf0
Compare
Hey @notomo, sorry this PR has sat without review for so long. Since it was opened both @mislav and @vilmibm left the company. I assigned it to myself to review to try and get things moving again. Is this something you are still interested in getting merged in? If so, do you feel like there's anything more you would like to do before I review it? |
b24cdf0
to
f5918e9
Compare
Thanks for mentioning!
Yes.
Now I resolved conflict. This is ready to review. |
Alright, thanks for resolving that. Just to give you a heads up, since this work was initially planned in #390, there has been additional discussion around delaying PR/Issue command improvements in light of #7575. It may be that we hold off on merging this until we get more clarity around how we want to approach this other work. In the meantime, I wanted to make sure you were still interested, and to communicate exactly what the state of this PR is. You have put some work into it and it doesn't look like we've been valuing your time with clear communication. We will try to prioritise this PR and communication going forward. |
I have also added this PR to the list of improvements on the tracking issue. |
@notomo : firstly, let me apologize on behalf of the entire GitHub CLI team regarding how long this PR has languished due to our circumstances! 🙇 thank you, sincerely! 🫶 Seeing how this has languished, I've committed to reviewing this and working with you to shape these changes up if it is something you're still motivated working on. With that said, I think there are several product / user experience questions to ask outside of this PR in order to shape it. As such, I'm following up in #390 (comment) for to gauge community feedback and interest. |
Thanks! I agree to discuss before proceeding this PR. |
Part of #390