Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add headers to all tables #8157

Merged
merged 8 commits into from
Oct 20, 2023
Merged

Add headers to all tables #8157

merged 8 commits into from
Oct 20, 2023

Commits on Oct 19, 2023

  1. Add headers to all tables 

    Resolves cli#8090
    @heaths @samcoe
    heaths authored and samcoe committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    e5a7ccc View commit details
    Browse the repository at this point in the history

  2. Better enforce header option at compile time 

    Require headerOption when constructing tableprinter.TablePrinter. Panic if headers are nil or empty - expected to be caught in tests.
    @heaths @samcoe
    heaths authored and samcoe committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    54c8022 View commit details
    Browse the repository at this point in the history

  3. Use black+b color for headers

    @heaths @samcoe
    heaths authored and samcoe committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    c2bf094 View commit details
    Browse the repository at this point in the history

  4. Use tableprinter.AddHeader and WithPadding 

    Applies consistent table header with underline spanning entire column
width.
    @heaths @samcoe
    heaths authored and samcoe committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    fe7e37b View commit details
    Browse the repository at this point in the history

  5. Resolve PR feedback

    @heaths @samcoe
    heaths authored and samcoe committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    7bf8910 View commit details
    Browse the repository at this point in the history

  6. Fix up tests

    @samcoe
    samcoe committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    5a19a46 View commit details
    Browse the repository at this point in the history

  7. Some polish and style nits

    @samcoe
    samcoe committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    d727f0b View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Rename to LightGrayUnderline

    @samcoe
    samcoe committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    d0fc645 View commit details
    Browse the repository at this point in the history