Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add attestation support #53

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

v1v
Copy link
Contributor

@v1v v1v commented May 14, 2024

@v1v v1v requested a review from a team as a code owner May 14, 2024 12:59
@v1v v1v requested a review from andyfeller May 14, 2024 12:59
Copy link
Contributor

@andyfeller andyfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v1v : firstly, thank you for opening up this PR and building upon the exciting new capability in v2.49.0! ❤️

Everything looks straight forward with a few suggestions around documentation and wordage. 🎉 My primary concern is attest is the opposite side of the coin of using these attestations to verify that a build has gone through expected processes in being created; this change merely generates and uploads the attestations. 🙇

README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@andyfeller
Copy link
Contributor

Want to put this on the @cli/package-security radar being new to contributing to the GitHub CLI; this action used by GitHub CLI extension authors to build and publish their extensions to gh-extension topic-based community.

This is the necessary first part before updating the GitHub CLI to check for extensions' attestations before installing or upgrading, which we haven't discussed yet.

Co-authored-by: Andy Feller <andyfeller@github.com>
@v1v v1v requested a review from andyfeller May 14, 2024 16:12
Copy link
Contributor

@andyfeller andyfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

animated cat giving enthusiastic 2 thumbs up

@andyfeller andyfeller merged commit 309b2c2 into cli:trunk May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants