Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GQLCLient should return GQLError for query and mutation methods #97

Closed
samcoe opened this issue Jan 16, 2023 · 0 comments · Fixed by #95
Closed

GQLCLient should return GQLError for query and mutation methods #97

samcoe opened this issue Jan 16, 2023 · 0 comments · Fixed by #95
Assignees

Comments

@samcoe
Copy link
Contributor

samcoe commented Jan 16, 2023

Right now the query and mutations methods on GQLCLient return an error type from shurcooL-graphql which does not match the concrete error type from the do methods. This causes unnecessary complexity when trying to do type assertion on the errors returned from the GQLCLient methods. To fix this we can wrap the errors returned from query and mutations methods in a GQLError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant