Replace shurcool Errors in GQLError #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcoe
changed the title
mislav
approved these changes
Feb 16, 2023
| Type: e.Type, | ||
| } | ||
| } | ||
| err = &GQLError{items} |
There was a problem hiding this comment.
This change could easily be backwards-compatible if GQLError implemented Unwrap() error that returned the original graphql.Errors instance
samcoe
added a commit
that referenced
this pull request
Mar 18, 2023
samcoe
added a commit
that referenced
this pull request
Mar 20, 2023
samcoe
added a commit
that referenced
this pull request
Apr 5, 2023
samcoe
added a commit
that referenced
this pull request
Apr 16, 2023
* Fix up repository package * Refactor api package * Fix up browser package * Fix up config package * Fix up template package * Wrap shurcool Errors in GQLError (#104) * Rename CurrentRepository to Current * Fix up tests * Change all references of GQL to GraphQL and references of gql to graphQL * Update to Go 1.20 * Update package to V2 * Update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97
Note this is based on the v2 branch as I felt this also could be considered a breaking change and thought it belonged with the other changes that will go into v2. If we felt like making this a non-breaking change we could also allow the
GQLErrorto actuallyWrap/Unwrapthe shurcool error we received.