Only successful installs should be cached

Make sure not to leave inconsistent data behind. If the install failed, delete the pacakge dir, and the JSON cache
clibs · Nov 18, 2022 · 0c19a04 · 0c19a04
1 parent 90114c2
commit 0c19a04
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/common/clib-package.c b/src/common/clib-package.c
@@ -1609,8 +1609,10 @@ int clib_package_install(clib_package_t *pkg, const char *dir, int verbose) {
     clib_cache_save_package(pkg->author, pkg->name, pkg->version, pkg_dir);
     _debug("cached package: %s/%s@%s", pkg->author, pkg->name, pkg->version);
   } else {
-    clib_cache_delete_json(pkg->author, pkg->name, pkg->version);
-    _debug("deleted json cache: %s/%s@%s", pkg->author, pkg->name, pkg->version);
+    if (pkg) {
+      clib_cache_delete_json(pkg->author, pkg->name, pkg->version);
+      _debug("deleted json cache: %s/%s@%s", pkg->author, pkg->name, pkg->version);
+    }
   }
 #ifdef HAVE_PTHREADS
   pthread_mutex_unlock(&lock.mutex);