Windows port #26
Closed
Windows port #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
at a glance, this looks good!! however, editing dependencies isn't really the desired approach here. we should think of i'll take a more trough look a bit later and possibly just update the dependencies directly. |
|
regarding go, see #2. |
|
@mattn any way you could revert commits touching deps? |
|
Ok, I'll look into it in later. |
|
I'll make new issue with rebased. |
|
It seems that my commits are merged in each sub-projects. 👍 |
|
Ah, need to create PR for Makefile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, below is a patch for windows. Please review. :)
BTW, I noticed some bugs which is non-free, overrun, broken pointer. I prefer to use golang instead of C. Go don't need dependency shared libraries, have GC, portability, many useful libraries. How about to replace to go?